Skip to content

GH-45670: [Release][Archery] Crossbow bot accepts --prefix#45671

Merged
kou merged 1 commit intoapache:mainfrom
kou:crossbow-bot-prefix
Mar 5, 2025
Merged

GH-45670: [Release][Archery] Crossbow bot accepts --prefix#45671
kou merged 1 commit intoapache:mainfrom
kou:crossbow-bot-prefix

Conversation

@kou
Copy link
Member

@kou kou commented Mar 5, 2025

Rationale for this change

I want to find binary verification jobs in a release PR easily for GH-45548.
Example jobs: #45502 (comment)

If we use specific prefix for the jobs, we can find them easily.

What changes are included in this PR?

Make prefix customizable by an option.

Are these changes tested?

No.

Are there any user-facing changes?

No.

@github-actions
Copy link

github-actions bot commented Mar 5, 2025

⚠️ GitHub issue #45670 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Mar 5, 2025
@assignUser
Copy link
Member

Can't look into the code right now but I thought this was possible already, i.e. when we run nightly and packaging etc.

@kou
Copy link
Member Author

kou commented Mar 5, 2025

We can do it by archery crossbow submit ... from command line but can't do it with @github-actions crossbow submit ... on PR...

@assignUser
Copy link
Member

Ah ok, makes sense!

@kou kou merged commit 601fde9 into apache:main Mar 5, 2025
8 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Mar 5, 2025
@kou kou deleted the crossbow-bot-prefix branch March 5, 2025 05:47
@kou
Copy link
Member Author

kou commented Mar 5, 2025

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 601fde9.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 9 possible false positives for unstable benchmarks that are known to sometimes produce them.

@jonkeane
Copy link
Member

jonkeane commented Mar 5, 2025

Ah nice! thank you for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants